Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Truncate inlay hint label #2514
Feature: Truncate inlay hint label #2514
Changes from 31 commits
1d85bcc
41150db
0c9f49c
9755ed2
5c86172
528a430
6335b74
8265c1b
c43d722
a882902
808e817
1ba72a6
1c313b5
25be2dd
c618857
cc4ad00
08b9795
9f0f3c7
1a09aa5
1a5bae4
0fcdf79
bc41741
abe0987
17591c1
09162a2
79fee60
19a991a
0496789
c6e0055
e5b9050
c4c74cc
b83a147
9be92d9
dc7d5ca
87db8f3
d6a544a
0a4a246
a43e68a
875a7a0
572b1cd
b039ea8
8e86dc3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this also be
>
here or not?I have tested the PR with a server that uses the regular label (no label parts) and I think it works well with the tooltips.
My only suggestion left would be to use a lower default value for the setting. I think 30 would be a sane default. I would say the truncation is actually a good thing to do, and some users might not check settings or read update notes, so it should be applied by default. Opinions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll check it out. Thanks for pointing that out.
I think inlay hint is not enabled by default, so most users will not be affected. So I agree that this feature should be enabled by default. I'll wait for more opinions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in d6a544a.
Done in a43e68a
I will not resolve this conversation in case of reconsideration, should I?