Use generated types for python 38 (#2500)

* use generated types for python 3.8

* remove CompletionEditRange because it is no longer necessary

* fix flake8

* LSP only supports TextEdits for WorkspaceChanges currently

In the future we could remove the is_text_edit check when we add support for  `AnnotatedTextEdit` and `SnippetTextEdit`

* Implement activeParameter being `null` in 3.18 in which case the client should not higlight any parameter

* cast langauge_id to LanguageKind

* I should really setup flake8 locally

* a

* set "noActiveParameterSupport" to False

* remove accidentally committed file

* add space

* remove noActiveParameterSupport": False

* import on separate line

* one import per line

* change Enum to StrEnum

* remove unused import

* sort lines

* remove casting

* remove uint

* fix detecting textEdits not applying because .get('newText') was falsy

{'range': {'start': {'line': 1, 'character': 0}, 'end': {'line': 2, 'character': 0}}, 'newText': ''}

* address type issue

* allowed AnnotatedTextEdit

* fix syntax

---------

Co-authored-by: Rafał Chłodnicki <[email protected]>
Co-authored-by: Rafal Chlodnicki <[email protected]>

plugin/completion.py

@@ -3,7 +3,7 @@
 from .core.edit import apply_text_edits
 from .core.logging import debug
 from .core.promise import Promise
-from .core.protocol import CompletionEditRange
+from .core.protocol import EditRangeWithInsertReplace
 from .core.protocol import CompletionItem
 from .core.protocol import CompletionItemDefaults
 from .core.protocol import CompletionItemKind
@@ -127,7 +127,7 @@ def is_range(val: Any) -> TypeGuard[Range]:
     return isinstance(val, dict) and 'start' in val and 'end' in val
 
 
-def is_edit_range(val: Any) -> TypeGuard[CompletionEditRange]:
+def is_edit_range(val: Any) -> TypeGuard[EditRangeWithInsertReplace]:
     return isinstance(val, dict) and 'insert' in val and 'replace' in val
 
 

plugin/core/edit.py

@@ -1,14 +1,15 @@
 from __future__ import annotations
 from .logging import debug
+from .protocol import AnnotatedTextEdit
 from .protocol import Position
 from .protocol import TextEdit
 from .protocol import UINT_MAX
 from .protocol import WorkspaceEdit
-from typing import Dict, List, Optional, Tuple
+from typing import Dict, List, Optional, Tuple, Union
 import sublime
 
 
-WorkspaceChanges = Dict[str, Tuple[List[TextEdit], Optional[int]]]
+WorkspaceChanges = Dict[str, Tuple[List[Union[TextEdit, AnnotatedTextEdit]], Optional[int]]]
 
 
 def parse_workspace_edit(workspace_edit: WorkspaceEdit) -> WorkspaceChanges:
@@ -24,7 +25,11 @@ def parse_workspace_edit(workspace_edit: WorkspaceEdit) -> WorkspaceChanges:
             uri = text_document['uri']
             version = text_document.get('version')
             edits = document_change.get('edits')
-            changes.setdefault(uri, ([], version))[0].extend(edits)
+            for edit in edits:
+                if 'snippet' in edit:
+                    debug('Ignoring unsupported SnippetTextEdit')
+                    continue
+                changes.setdefault(uri, ([], version))[0].append(edit)
     else:
         raw_changes = workspace_edit.get('changes')
         if isinstance(raw_changes, dict):