Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground passes evalInContext to Slot #978

Merged
merged 2 commits into from
May 13, 2018

Conversation

kidkuro
Copy link
Contributor

@kidkuro kidkuro commented May 9, 2018

Fixes #977

Playground passes evalInContext to Slot

@kidkuro
Copy link
Contributor Author

kidkuro commented May 10, 2018

I am getting 503 errors attempting to run Cyprus locally to try to reproduce the problem. The error seems unlikely to be related to my change, since this simply passes an extra config option which isn't being used. Not sure how to proceed from here.

@kidkuro
Copy link
Contributor Author

kidkuro commented May 11, 2018

The "Single component preview section changes the render after code change" is failing with a timeout. The code waits for 500ms. I just tried manually executing the scenario by typing into the code editor... and it looks like the lag between type and update could easily exceed that timeout in a real browser environment. Could it be that timeout is too short and is fragile? Again... this doesn't appear to be due to my change.

@sapegin
Copy link
Member

sapegin commented May 11, 2018

Yeah, we have some issues with this test: #895

Restarting the CI usually helps.

@sapegin sapegin merged commit 3a2fba0 into styleguidist:master May 13, 2018
@sapegin
Copy link
Member

sapegin commented May 13, 2018

Thanks!

(I’ve also increased the timeout in that test — hope it would help, couldn't find a way to avoid the timeout unfortunately.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants