Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Webpack 5 upgrade #1996

Merged
merged 56 commits into from
Sep 5, 2022
Merged

Conversation

ThomasRoest
Copy link
Collaborator

@ThomasRoest ThomasRoest commented Apr 19, 2022

This is a start for upgrading to webpack 5 and webpack-dev-server ^4. With these changes, the basic examples are working ( incl. hot module reloading ). But there are more todo's left

Todo

  • update dev-server config
  • make StyleguidistOptionsPlugin.ts work with webpack 5 and fix test
  • fix make-webpack-config.spec.ts tests
  • upgrade other webpack loader dependencies to latests versions (optional?)
  • fix type errors
  • fix deprecation warnings

This fixes some issues like #1932
This requires a new major release

@ThomasRoest
Copy link
Collaborator Author

@sapegin What is your vision concerning the future of this project? I'm willing to help out with some maintenance ( like this pull request ). Do you have time to review / accept these updates?

Copy link
Member

@sapegin sapegin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the pull request! I'm happy to give you more rights here if you have time and the desire to work on the project. Unfortunately, I don't have either right now.

https://blog.sapegin.me/all/going-offline/

Thomas Roest added 2 commits May 17, 2022 10:22
The validate function no longer returns an array with errors, but just throws errors for invalid configs
@ThomasRoest
Copy link
Collaborator Author

ThomasRoest commented May 17, 2022

Hey, thanks for the pull request! I'm happy to give you more rights here if you have time and the desire to work on the project. Unfortunately, I don't have either right now.

https://blog.sapegin.me/all/going-offline/

sure! I'll mainly work on updating dependencies. There is one issue however that I might need help with, as it seems that the algolia search is no longer working...#1992

@sapegin
Copy link
Member

sapegin commented May 17, 2022

I gave you write access to the repository ;-)

@ThomasRoest ThomasRoest self-assigned this May 18, 2022
The previous implementation resulted in the following error
`TypeError: The 'compilation' argument must be an instance of Compilation`

Instead of using a plain obj mock, use jest.mock to mock webpack.
@codecov
Copy link

codecov bot commented May 30, 2022

Codecov Report

Merging #1996 (cd02637) into master (4c55077) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
...ent/rsg-components/Arguments/ArgumentsRenderer.tsx 100.00% <ø> (ø)
.../client/rsg-components/Methods/MethodsRenderer.tsx 100.00% <ø> (ø)
src/client/rsg-components/Usage/Usage.tsx 100.00% <ø> (ø)
src/scripts/make-webpack-config.ts 100.00% <ø> (ø)
src/client/rsg-components/Editor/Editor.tsx 100.00% <100.00%> (ø)
...onents/Markdown/Details/DetailsSummaryRenderer.tsx 100.00% <100.00%> (ø)
src/client/rsg-components/Preview/Preview.tsx 100.00% <100.00%> (+2.56%) ⬆️
...ent/rsg-components/TabButton/TabButtonRenderer.tsx 100.00% <100.00%> (ø)
...onents/TableOfContents/TableOfContentsRenderer.tsx 100.00% <100.00%> (ø)
src/client/utils/compileCode.ts 100.00% <100.00%> (ø)
... and 12 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants