-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Webpack 5 upgrade #1996
WIP: Webpack 5 upgrade #1996
Conversation
@sapegin What is your vision concerning the future of this project? I'm willing to help out with some maintenance ( like this pull request ). Do you have time to review / accept these updates? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for the pull request! I'm happy to give you more rights here if you have time and the desire to work on the project. Unfortunately, I don't have either right now.
The validate function no longer returns an array with errors, but just throws errors for invalid configs
sure! I'll mainly work on updating dependencies. There is one issue however that I might need help with, as it seems that the algolia search is no longer working...#1992 |
I gave you write access to the repository ;-) |
The previous implementation resulted in the following error `TypeError: The 'compilation' argument must be an instance of Compilation` Instead of using a plain obj mock, use jest.mock to mock webpack.
Codecov Report
|
merge commits Arnout
Also removed Webpack 4 support.
fix: TypeScript errors in StyleguidistOptionsPlugin
This fixes build error / failing npm ci command: `npm ci` can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with `npm install` before continuing
This is a start for upgrading to webpack 5 and webpack-dev-server ^4. With these changes, the basic examples are working ( incl. hot module reloading ). But there are more todo's left
Todo
This fixes some issues like #1932
This requires a new major release