-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for the experimental syntax 'dynamicImport' isn't currently enabled #987
Comments
I'm wondering why are they enabling Babel inside node_modules. |
Here is proposal for it facebook/create-react-app#3776 |
I think we should open an issue there, because they say “Verify this doesn't break third-party code” — but it breaks ;-) And they don't have to compile imports, just allow the syntax. Would you mind opening an issue at create-react-app? |
Yes will open. Thanks for the tip |
For what it's worth, I was able to successfully get this running by installing plugin-syntax-dynamic-import then add a .babelrc using create-react-app and react-scripts version 1.1.4. I'm sure mileage will vary. npm install @babel/plugin-syntax-dynamic-import .babelrc {
"plugins": ["@babel/plugin-syntax-dynamic-import"]
} |
create-react-app bug report confirmed. Will close this UPD: it is confirmed by not maintainer (facepalm). Why would you write "bug confirmed", if you are not maintainer, but whatever |
Yeah, probably should have made that more clear. Maybe "successfully duplicated" would have been more clear? 🤷♂️ |
@sapegin can you please take a part in the discussion in create-react-app 🙌. They try to understand if it is easier drop dynamic import in styleguidist or allow it in node_modules. facebook/create-react-app#3776 Thanks |
I don't see any discussion there, is that the right link? |
Oh sorry, I meant facebook/create-react-app#4477 (comment) |
This may be a good solution for that: #1054. |
This was fixed on CRA side, closing. |
Current behavior
To reproduce
Demo is not based on template, but I guess this doesn't matter because issue is with
react-scripts@next
.Issue happens with [email protected] and [email protected].
But not with [email protected] and [email protected].
Expected behavior
No error
The text was updated successfully, but these errors were encountered: