Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up methods in Connect and MM2 Assembly Operators #10640

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Clean up methods in Connect and MM2 Assembly Operators #10640

merged 1 commit into from
Sep 27, 2024

Conversation

katheris
Copy link
Contributor

@katheris katheris commented Sep 25, 2024 •
edited
Loading

Type of change

Select the type of your PR

  • Refactoring

Description

Clean up methods in Connect and MM2 Assembly Operators:

  • Move methods to align them across the KafkaConnectAssemblyOperator, KafkaMirrorMaker2AssemblyOperator and AbstractConnectOperator
  • Use port field directly instead of hard coded KafkaConnectCluster.REST_API_PORT
  • Refactor connector reconcile methods in KafkaConnectAssemblyOperator to make it easier to follow

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

@katheris katheris force-pushed the cleanupConnectMm2 branch 2 times, most recently from 7cd460d to 6999a87 Compare September 26, 2024 09:10
@katheris katheris marked this pull request as ready for review September 26, 2024 12:01
@katheris katheris added this to the 0.44.0 milestone Sep 26, 2024
@katheris katheris requested a review from scholzj September 26, 2024 12:01
scholzj
scholzj approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@scholzj
Copy link
Member

scholzj commented Sep 26, 2024

/azp run regression

@scholzj scholzj requested a review from ppatierno September 26, 2024 14:38
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scholzj scholzj merged commit babae9e into strimzi:main Sep 27, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scholzj scholzj scholzj approved these changes

@ppatierno ppatierno ppatierno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.44.0
Development

Successfully merging this pull request may close these issues.
3 participants
@katheris @scholzj @ppatierno