Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add current raft state to grafana dashboard #10548

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Conversation

MichaelMorrisEst
Copy link
Contributor

Type of change

  • Enhancement / new feature

Description

Adds the current Raft state metric to the grafana dashboard as a table as per screenshot below

image

Closes #10538

Checklist

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Could you please:

  • Move the change to packaging/examples/...? The files in examples/... are the released files which change only with a new release.
  • Once you do that, can you please run make dashboard_install to lso copy the change into the Helm Chart?

Thanks.

@scholzj scholzj added this to the 0.44.0 milestone Sep 6, 2024
@scholzj scholzj requested a review from ppatierno September 6, 2024 13:06
Signed-off-by: MichaelMorris <[email protected]>
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it in my environment and it looks great.

The only thing I was wondering about is whether there issome way to sort the table? Right now it seems to have no soerting and with every update of the dashabord the lines reorder, so it is hard to read sometimes and acts a bit disruptively as it keeps changing.

Signed-off-by: MichaelMorris <[email protected]>
@MichaelMorrisEst
Copy link
Contributor Author

Sorted now by pod name:

image

Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot.

Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR!

@ppatierno ppatierno merged commit e5a7bc6 into strimzi:main Sep 10, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the current Raft state to the KRaft Grafana dashboard
3 participants