-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add current raft state to grafana dashboard #10548
Conversation
Signed-off-by: MichaelMorris <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Could you please:
- Move the change to
packaging/examples/...
? The files inexamples/...
are the released files which change only with a new release. - Once you do that, can you please run
make dashboard_install
to lso copy the change into the Helm Chart?
Thanks.
Signed-off-by: MichaelMorris <[email protected]>
968d637
to
250b2d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried it in my environment and it looks great.
The only thing I was wondering about is whether there issome way to sort the table? Right now it seems to have no soerting and with every update of the dashabord the lines reorder, so it is hard to read sometimes and acts a bit disruptively as it keeps changing.
Signed-off-by: MichaelMorris <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks a lot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the PR!
Type of change
Description
Adds the current Raft state metric to the grafana dashboard as a table as per screenshot below
Closes #10538
Checklist