Fix duplicate clustersrolebindings issue

[Eric84626]

Type of change

• Bugfix

Description

Duplicate ClusterRoleBindings will be attempted to be created when we set watchAnyNamespace to true and add some namespaces to watchNamespaces.

Fixes: #10378

Checklist

Please go through this checklist and make sure all applicable tasks have been done

• Write tests
• Make sure all tests pass
• Update documentation
• Check RBAC rights for Kubernetes / OpenShift roles
• Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
• Reference relevant issue(s) and close them after merging
• Update CHANGELOG.md
• Supply screenshots for visual changes, such as Grafana dashboards

[scholzj]

Thanks for the PR. I left some questions for some more explanation.

[scholzj]

As we are not really Helm experts, would you mind explaining (perhaps int he PR description) what exactly does this code do?

[Eric84626]

Sure @scholzj

[scholzj]

Out of curiosity, what does the - at the end do here?

[Eric84626]

Notice that we received a few empty lines in our YAML. Why? When the template engine runs, it removes the contents inside of {{ and }}, but it leaves the remaining whitespace exactly as is.

YAML ascribes meaning to whitespace, so managing the whitespace becomes pretty important. Fortunately, Helm templates have a few tools to help.
First, the curly brace syntax of template declarations can be modified with special characters to tell the template engine to chomp whitespace. {{- (with the dash and space added) indicates that whitespace should be chomped left, while -}} means whitespace to the right should be consumed. Be careful! Newlines are whitespace!

If it is the first line in a yaml file, I think it will not impact anything.
If you concern about it, I can remove - at the end.

[scholzj]

/azp run helm-acceptance

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[Eric84626]

I defined a new variable - "watchNamespaces", the default value is .Values.watchNamespaces.

[Eric84626]

If "watchAnyNamespace" is set to true, we will set variable watchNamespaces to empty List, and ignore the values of ".Values.watchNamespaces"

Loop over new variable($watchNamespaces) instead of ".Values.watchNamespaces"

[Eric84626]

Notice that we received a few empty lines in our YAML. Why? When the template engine runs, it removes the contents inside of {{ and }}, but it leaves the remaining whitespace exactly as is.

YAML ascribes meaning to whitespace, so managing the whitespace becomes pretty important. Fortunately, Helm templates have a few tools to help.
First, the curly brace syntax of template declarations can be modified with special characters to tell the template engine to chomp whitespace. {{- (with the dash and space added) indicates that whitespace should be chomped left, while -}} means whitespace to the right should be consumed. Be careful! Newlines are whitespace!

If it is the first line in a yaml file, I think it will not impact anything.
If you concern about it, I can remove - at the end.

[scholzj]

Thanks a lot for the explanations. That is a big help.

[tombentley]

Thanks!