assert: fix flaky TestNeverTrue #1417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cc: @SuperQ @brackendawson for review |
brackendawson
requested changes
Jul 18, 2023
Fix flaky TestNeverTrue: use a channel to make a synchronized list of return values to avoid a race condition.
dolmen
force-pushed
the
assert-fix-flaky-TestNeverTrue
branch
from
55b9534 to
cd26798
Compare
|
@brackendawson Fixed and rebased. Ready for merge. |
brackendawson
approved these changes
Jul 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix flaky
TestNeverTrueinassertpackage: use a channel to make a synchronized counter to avoid a race condition.Changes
Refactor TestNeverTrue to synchronize the counter.
Motivation
Fix flaky test which make CI unreliable.
$ go test -race -failfast -count=100 ./...Related issues