-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow mock expectations to be ordered #1106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for your contribution :)
When will this be merged? |
Are we missing something to merge this? |
There are conflicts to resolve on |
There you go. 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!
Summary
Allow mock expectations to be ordered
Changes
Call
to be used inMock.ExpectedCalls
a[]*Call
which must all be satisfied first.Call.NotBefore()
to allow the above to be populated.Mock.checkExpectation()
.Motivation
People want to check that some calls were made in a necessary order.
Related issues
Closes #741