Stop using protobuf.js for encoding/decoding on Kotlin/JS #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves a bunch of protobuf conformance test failures on Kotlin/JS that were being caused by protobuf.js. It also removes a dependency. There's a possibility that the protobuf.js implementation of low-level protobuf encoding/decoding is more optimized for JS runtimes than pbandk's Kotlin-based implementation. But I'd rather spend time on optimizing pbandk's implementation, which would also benefit other platforms in addition to Kotlin/JS, than on fighting bugs in protobuf.js that aren't going to be fixed any time soon. Also replaced the `utf8Len()` implementation that was based on code from Google's Protobuf Java library with a simpler implementation derived from Okio code.
garyp
force-pushed
the
garyp/remove-protobufjs
branch
from
2567123 to
5d37d92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves a bunch of protobuf conformance test failures on Kotlin/JS that were being caused by protobuf.js. It also removes a dependency. There's a possibility that the protobuf.js implementation of low-level protobuf encoding/decoding is more optimized for JS runtimes than pbandk's Kotlin-based implementation. But I'd rather spend time on optimizing pbandk's implementation, which would also benefit other platforms in addition to Kotlin/JS, than on fighting bugs in protobuf.js that aren't going to be fixed any time soon.
Also replaced the
utf8Len()implementation that was based on code from Google's Protobuf Java library with a simpler implementation derived from Okio code.