Add support for more Kotlin/Native targets #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `iosSimulatorArm64`, tvOS, and `linuxArm64` targets. Fixes #218
rahulreddym
approved these changes
May 3, 2022
There was a problem hiding this comment.
Looks good but for completeness we can add watchOS targets too
publishWatchosArm32PublicationToMavenLocal publishWatchosArm64PublicationToMavenLocal publishWatchosSimulatorArm64PublicationToMavenLocal publishWatchosX86PublicationToMavenLocal publishWatchosX64PublicationToMavenLocal
|
@rahulreddym Thanks for the review! Yeah I had thought about adding more platforms, including watchOS. The problem is that Kotlin/Native targets are very slow to compile and it already takes forever to build pbandk in CI. This reminded me that I should create an issue for speeding up CI builds: #220. We can add the remaining Native platforms once that's addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
iosSimulatorArm64, tvOS, andlinuxArm64targets.Fixes #218