Add support for proto2 required fields #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also refactor some of the `hasPresence`-related code in the code generator to make it easier to understand. Fixes #71.
garyp
force-pushed
the
bug/GH-71-required-default-values
branch
from
b44f412 to
f5bb168
Compare
garyp
added a commit
that referenced
this pull request
Mar 7, 2023
Also refactor some of the `hasPresence`-related code in the code generator to make it easier to understand. Fixes #71. There's a lot of noise in this PR from empty lines being added to generated code. The interesting changes are in `File.kt`, `FileBuilder.kt` and `CodeGenerator.kt` under `protoc-gen-pbandk/lib/src/commonMain/kotlin/pbandk/gen/`. You can see an example of how these changes impact the generated code in `runtime/src/commonMain/kotlin/pbandk/wkt/descriptor.kt`, where a couple `required` fields in the `NamePart` message were previously being generated incorrectly and now are handled properly. Aside from the main changes, there is also some slight refactoring of the `kotlinJavaRoundtripTest()` method used in some of the tests (and the method also got renamed to `pbandkJavaRoundtripTest()`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also refactor some of the
hasPresence-related code in the code generator to make it easier to understand.Fixes #71.
Guide to changes
There's a lot of noise in this PR from empty lines being added to generated code. The interesting changes are in
File.kt,FileBuilder.ktandCodeGenerator.ktunderprotoc-gen-pbandk/lib/src/commonMain/kotlin/pbandk/gen/. You can see an example of how these changes impact the generated code inruntime/src/commonMain/kotlin/pbandk/wkt/descriptor.kt, where a couplerequiredfields in theNamePartmessage were previously being generated incorrectly and now are handled properly.Aside from the main changes, there is also some slight refactoring of the
kotlinJavaRoundtripTest()method used in some of the tests (and the method also got renamed topbandkJavaRoundtripTest()).