Enable Kotlin's explicit API mode; add visibility paramater to protoc-gen-pbandk
#191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyp
force-pushed
the
garyp/explicit-api
branch
from
850d8f6 to
7c713bf
Compare
garyp
force-pushed
the
garyp/kotlin-1.5
branch
2 times, most recently
from
1ddf53c to
736f854
Compare
…r to protoc-gen-pbandk Added the ability to compile pbandk-generated code with Kotlin's "explicit API" mode turned on. This requires all types/functions/etc. to have their visibility (`public`/`internal`/`private`) explicitly specified and, if they're public, have their type explicitly specified. Also added a `visibility` option for `protoc-gen-pbandk` to allow changing the visibility of pbandk-generated code from the default `public` visibility to `internal`. Fixes #190.
Fixes #134.
garyp
force-pushed
the
garyp/explicit-api
branch
from
7c713bf to
b23834a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to compile pbandk-generated code with Kotlin's "explicit API" mode turned on. This requires all types/functions/etc. to have their visibility (
public/internal/private) explicitly specified and, if they're public, have their type explicitly specified. In addition, turned on "explicit API" mode for pbandk itself.Also added a
visibilityoption forprotoc-gen-pbandkto allow changing the visibility of pbandk-generated code from the defaultpublicvisibility tointernal.