Update to Kotlin 1.5, related version bumps, and add macosArm64 target #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyp
force-pushed
the
garyp/kotlin-1.5
branch
4 times, most recently
from
698b2f3 to
1ddf53c
Compare
Kotlin 1.5 doesn't allow opt-in annotations on constructor parameters. So a data class property declared in the constructor needs to be annotated with `@property:` so that the annotation only applies to the property and not to the constructor parameter. Kotlin 1.5 also no longer allows opt-in annotations on property getters.
The Kotlin/JS IR compiler in Kotlin 1.5 no longer allows interfaces to be annotated with `@JsExport`. This caused some strong developer pushback and is going to be relaxed in Kotlin 1.6.20: https://youtrack.jetbrains.com/issue/KT-45434#focus=Comments-27-5349163.0-0. Once that is released, we can hopefully reintroduce the `@JsExport` annotation on interfaces.
garyp
force-pushed
the
garyp/kotlin-1.5
branch
from
1ddf53c to
736f854
Compare
seanadkinson
approved these changes
Dec 2, 2021
|
|
||
| val jsTest by getting { | ||
| dependencies { | ||
| implementation(kotlin("test-js")) |
There was a problem hiding this comment.
Whatever this dependency provided is included in kotlin("test") now?
There was a problem hiding this comment.
Yep. Kotlin 1.5 simplified the test dependencies so you can now just add a kotlin("test") dependency to the common source set and it'll pull in the correct dependencies on each platform automatically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit contains the actual Kotlin 1.5 update. Second commit adds the
macosArm64()target. Remaining commits fix up compiler warnings flagged by the new Kotlin 1.5 compiler.Fixes #171