Download protoc from maven for all protoc tasks #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustinbrown
approved these changes
May 7, 2021
…y downloaded proto files This pulled in a newer version of `plugin.proto` with a recently-added field.
We no longer need to pass `protoc.path` to gradle, nor download and compile `protoc` manually, when building pbandk. The protobuf source does still need to be downloaded for running conformance tests since the conformance test runner is not available as a maven artifact. This functionality was already being used by the `DescriptorProtocTask` in `protoc-gen-kotlin`. That task was a copy of the `ProtocTask` with some changes made. This PR updates `ProtocTask` so it can be used as the parent for `DescriptorProtocTask`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer need to pass
protoc.pathto gradle, nor download and compileprotocmanually, when building pbandk. The protobuf source does still need to be downloaded for running conformance tests since the conformance test runner is not available as a maven artifact.This functionality was already being used by the
DescriptorProtocTaskinprotoc-gen-kotlin. That task was a copy of theProtocTaskwith some changes made. This PR updatesProtocTaskso it can be used as the parent forDescriptorProtocTask.Also updated protoc-gen-kotlin's
generatePrototask to use the automatically downloaded proto files that were added in the previous PR.