Fix performance problems when compiling generated code with Kotlin 1.4 #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyp
changed the title
When a protobuf message definition contains a lot of fields/oneofs, the generated Kotlin code cannot be compiled by a Kotlin 1.4 compiler. The compiler runs out of memory when compiling the long list of `FieldDescriptor`s that gets passed to the `MessageDescriptor`. This change implements a workaround that avoids the Kotlin compiler bug by initializing the list of `FieldDescriptor`s outside of the `MessageDescriptor` constructor. Also add a test proto file to catch regressions with large protobuf messages. Fixes #94
garyp
force-pushed
the
bug/GH-94-kotlin-1.4-perf-regression
branch
from
8c61e26 to
cb41f42
Compare
Closed
dustinbrown
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a protobuf message definition contains a lot of fields/oneofs, the generated Kotlin code cannot be compiled by a Kotlin 1.4 compiler. The compiler runs out of memory when compiling the long list of
FieldDescriptors that gets passed to theMessageDescriptor. This change implements a workaround that avoids the Kotlin compiler bug by initializing the list ofFieldDescriptors outside of theMessageDescriptorconstructor.Also add a test proto file to catch regressions with large protobuf messages.
The first commit contains all of the interesting changes. The second commit is just the result of running the gradle command to regenerate all proto definitions.
Fixes #94