-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pbandk release can't be used on a Java 1.8 project #211
Comments
Most of our day-to-day testing of pbandk is on Java 11, but we do support using pbandk with Java 8. This looks like a possible bug in the gradle config of the |
garyp
added a commit
that referenced
this issue
Mar 17, 2022
Without an explicit definition of the Java language version, gradle will default to building artifacts that depend on the same version of Java that gradle was running under. To guarantee that we don't break compatibility with existing pbandk users, we need to explicitly tell gradle to set the language version older than the currently-running Java version. Fixes #211.
garyp
added a commit
that referenced
this issue
Mar 17, 2022
Without an explicit definition of the Java language version, gradle will default to building artifacts that depend on the same version of Java that gradle was running under. To guarantee that we don't break compatibility with existing pbandk users, we need to explicitly tell gradle to set the language version older than the currently-running Java version. Also update the example project to use Java 8 when building to ensure that pbandk works correctly in a Java 8 project. Fixes #211.
garyp
added a commit
that referenced
this issue
Mar 17, 2022
Update pbandk-protos library to be Java 8 compatible
This is now fixed in the latest SNAPSHOT builds (should be available in a few minutes) and will go out in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
So, I have pbandk imported on my
build.gradle.kts
like:implementation("pro.streem.pbandk:pbandk-runtime:0.13.1-SNAPSHOT")
I also have this configureEach that seemed necessary for pbandk to work with Java 1.8
tasks.withType<KotlinCompile>().configureEach { kotlinOptions { jvmTarget = "1.8" } }
However, I'm having trouble compiling my project:
Is there a different way to import pbandk so I can use Java 1.8? I was not intending to use Java 1.8 but it seems necessary to use if I want to point my Firebase settings to local.
The text was updated successfully, but these errors were encountered: