Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable support for new Kotlin JS IR backend #136

Closed
garyp opened this issue Mar 12, 2021 · 0 comments · Fixed by #147
Closed

Enable support for new Kotlin JS IR backend #136

garyp opened this issue Mar 12, 2021 · 0 comments · Fixed by #147
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone
0.12.0

Comments

@garyp
Copy link
Collaborator

garyp commented Mar 12, 2021

See more ar https://kotlinlang.org/docs/reference/whatsnew14.html#new-js-ir-backend. We should use both mode to provide compatibility for pbandk users still using the old JS backend. We'll also need to add @JsExport annotations to public pbandk APIs to work with this new backend.
@garyp garyp added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Mar 12, 2021
@garyp garyp added this to the 0.11.0 milestone Mar 12, 2021
@itegulov itegulov mentioned this issue Apr 23, 2021
Merged
@garyp garyp closed this as completed in #147 Jun 6, 2021
garyp pushed a commit that referenced this issue Jun 6, 2021
@itegulov
Enable support for Kotlin/JS IR backend (#147)
aceb5a7 
* Enable `BOTH` Kotlin/JS backend for runtime and `IR` backend for conformance tests
* Mark all public runtime classes with `@JsExport`
* Annotate generated classes with `@pbandk.Export` by default, which is an alias to `@JsExport` under Kotlin/JS
* Increase gradle stack size
* Make JS Long-related methods compiler-backend-agnostic
* Stop conformance-lib from being built against browser: Module 'fs' is not available for browser environments which is a fatal error with IR compiler backend. Since we are using conformance tests specifically with NodeJS there is no reason to cross-build it for browsers anyway.
* Make `CodeGenerator` annotate `orDefault` with unique JS name to avoid conflicts

Fixes #136
@garyp garyp modified the milestones: 0.11.0, 0.12.0 Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
0.12.0
Development

Successfully merging a pull request may close this issue.

Enable support for Kotlin/JS IR backend and introduce js_export parameter itegulov/pbandk
1 participant
@garyp