Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sink create & update arguments #96

Merged
merged 6 commits into from
Jul 24, 2023
Merged

Conversation

nlu90
Copy link
Contributor

@nlu90 nlu90 commented Jul 23, 2023

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

add the following arguments:

--dead-letter-topic
--max-redeliver-count
--negative-ack-redelivery-delay-ms
--retain-key-ordering
--secrets
--sink-type

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@nlu90 nlu90 requested a review from a team as a code owner July 23, 2023 21:59
@github-actions github-actions bot added the doc-required This pr needs a document label Jul 23, 2023
Copy link
Member

@maxsxu maxsxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nlu90 Could you fix the CI tests?

freeznet
freeznet previously approved these changes Jul 24, 2023
pulsar/resource_pulsar_sink.go Outdated Show resolved Hide resolved
@maxsxu maxsxu merged commit 5e6dd18 into master Jul 24, 2023
@maxsxu maxsxu deleted the neng/add-sink-parameters branch July 24, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required This pr needs a document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants