Add retries to permission grant updates on Pulsar topics #91
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently I create a handful of permission grants per-topic using this Terraform provider.
Pulsar raises a
BadVersionException
when Terraform tries to create permission grants for multiple topics in the same namespace concurrently (see apache/pulsar#2952) - which results in the topic being created but not added to the TF state.Thus on subsequent applies, I have to manually import topics due to
code: 409 reason: This topic already exists
, and re-apply my TF module a few times before all my desired changes are applied.Modifications
Added a retry to the
updatePermissionGrants
operation in the Pulsar Topic resource as a workaround for Pulsar's undesirable behaviorVerifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation
Check the box below.
Need to update docs?
doc-required
(If you need help on updating docs, create a doc issue)
no-need-doc
no existing docs around when this TF provider retries operations
doc
(If this PR contains doc changes)