Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting journal size and tag size for integrity metadata pre-allocations on create #1110

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

mulkieran
Copy link
Member

No description provided.

@mulkieran mulkieran self-assigned this Nov 27, 2024
@mulkieran mulkieran force-pushed the integrity-pre branch 4 times, most recently from 059e7ab to 5bd84c3 Compare November 27, 2024 19:41
@mulkieran
Copy link
Member Author

mulkieran commented Dec 2, 2024

Current pool create help text:

usage: stratis pool create [-h] [--clevis {nbde,tang,tpm2}]
                           [--tang-url TANG_URL]
                           [--trust-url | --thumbprint THUMBPRINT]
                           [--journal-size JOURNAL_SIZE] [--tag-size TAG_SIZE]
                           [--key-desc KEY_DESC] [--no-overprovision]
                           pool_name blockdevs [blockdevs ...]

positional arguments:
  pool_name             Name of new pool
  blockdevs             Create the pool using these block devs

options:
  -h, --help            show this help message and exit
  --key-desc KEY_DESC   Key description of key in kernel keyring to use for
                        encryption
  --no-overprovision    Do not allow the sum of the logical size of the pool's
                        filesystems to exceed the size of the pool's data
                        area.

clevis:
  Arguments controlling creation with Clevis encryption

  --clevis {nbde,tang,tpm2}
                        Specification for binding with Clevis.
  --tang-url TANG_URL   URL of Clevis tang server (--clevis=[tang|nbde] must
                        be set)
  --trust-url           Omit verification of tang server credentials (--tang-
                        url option must be set)
  --thumbprint THUMBPRINT
                        Thumbprint of tang server (--tang-url option must be
                        set)

integrity:
  Optional parameters for configuring integrity metadata pre-allocation

  --journal-size JOURNAL_SIZE
                        Size of integrity device's journal. Each block is
                        written to this journal before being written to its
                        address. The size of must be a multiple of 4 KiB.
  --tag-size TAG_SIZE   Size of tag to use to verify correctness of 4KiB
                        block, e.g, 64B. Must be a power of 2 and less than
                        128B.

We could call the two newly added options, --integrity-journal-size and --integrity-tag-size.

@mulkieran mulkieran requested a review from drckeefe December 2, 2024 15:45
@mulkieran
Copy link
Member Author

man pages not yet written.

@mulkieran mulkieran changed the title Integrity pre Allow setting journal size and tag size for integrity metadata pre-allocations on create Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants