Use babel-preset-react-app preset as the default preset. #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunoda
commented
Oct 4, 2016
| cacheDirectory: true, | ||
| // It enables a cache directory for faster-rebuilds | ||
| // `find-cache-dir` will create the cache directory under the node_modules directory. | ||
| cacheDirectory: findCacheDir({ name: 'react-storybook' }), |
There was a problem hiding this comment.
This is not related to this PR but improves the caching process for babel.
arunoda
commented
Oct 4, 2016
| @@ -11,6 +11,8 @@ import packageJson from '../../package.json'; | |||
| import { parseList, getEnvConfig } from './utils'; | |||
| import { track, dontTrack } from './track_usage'; | |||
|
|
|||
| process.env.NODE_ENV = process.env.NODE_ENV || 'development'; | |||
There was a problem hiding this comment.
babel-preset-react-app preset only works if we set a proper value to NODE_ENV env variable.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With that, we could simply use a single preset rather managing them our own.
Preset: https://www.npmjs.com/package/babel-preset-react-app