Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Show checkmark icon in story status dropdown and update status label for component tests #29451

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Oct 25, 2024

What I did

Added missing checkmark icon to the story status menu, and updated the "Vitest" label to "Component tests".

Screenshot 2024-10-25 at 21 28 27

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 77.6 MB 77.6 MB 104 B -1.46 0%
initSize 146 MB 146 MB 1.05 kB -1.46 0%
diffSize 68.5 MB 68.5 MB 949 B 1.42 0%
buildSize 6.82 MB 6.82 MB -5 B -0.5 0%
buildSbAddonsSize 1.5 MB 1.5 MB 0 B -0.64 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 1.85 MB 1.85 MB -5 B 1.34 0%
buildSbPreviewSize 271 kB 271 kB 0 B 1.35 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 3.82 MB 3.82 MB -5 B -0.51 0%
buildPreviewSize 3 MB 3 MB 0 B 1 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 5.9s 20.8s 14.9s 1.14 71.6%
generateTime 20.6s 19.8s -768ms -0.67 -3.9%
initTime 14.1s 14.3s 156ms -0.29 1.1%
buildTime 10.4s 8.8s -1s -656ms -0.56 -18.8%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 9.3s 6s -3s -304ms -0.44 -54.5%
devManagerResponsive 6.2s 4.1s -2s -166ms -0.26 -52.5%
devManagerHeaderVisible 803ms 552ms -251ms -0.34 -45.5%
devManagerIndexVisible 921ms 616ms -305ms -0.08 -49.5%
devStoryVisibleUncached 1.8s 1.1s -699ms 0.52 -59.8%
devStoryVisible 852ms 615ms -237ms 0 -38.5%
devAutodocsVisible 717ms 470ms -247ms -0.69 -52.6%
devMDXVisible 747ms 456ms -291ms -0.67 -63.8%
buildManagerHeaderVisible 814ms 501ms -313ms -0.58 -62.5%
buildManagerIndexVisible 838ms 508ms -330ms -0.75 -65%
buildStoryVisible 774ms 503ms -271ms -1.15 -53.9%
buildAutodocsVisible 689ms 413ms -276ms -0.97 -66.8%
buildMDXVisible 679ms 441ms -238ms -0.71 -54%

Greptile Summary

Updates test status UI elements by adding a checkmark icon for successful tests in the status dropdown and changing the label from "Vitest" to "Component tests" across the interface.

  • Added StatusPassIcon for successful test status in code/core/src/manager/components/sidebar/Tree.tsx
  • Updated test status title from "Vitest" to "Component tests" in code/addons/test/src/manager.tsx
  • Maintains consistent labeling across UI components
  • Improves visual feedback for successful test states

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

Copy link

nx-cloud bot commented Oct 25, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8b08b4e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@valentinpalkovic valentinpalkovic merged commit 936293d into next Oct 28, 2024
59 of 63 checks passed
@valentinpalkovic valentinpalkovic deleted the story-status-menu-checkmark branch October 28, 2024 09:07
@github-actions github-actions bot mentioned this pull request Oct 28, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants