Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next.js: Upgrade sass-loader from ^13.2.0 to ^14.2.1 #29264

Merged
merged 16 commits into from
Nov 1, 2024

Conversation

HoncharenkoZhenya
Copy link
Contributor

@HoncharenkoZhenya HoncharenkoZhenya commented Oct 2, 2024

Closes #

What I did

Updated the sass-loader package version from ^13.2.0 to ^14.2.1 because the fibers package used in ^13.2.0 was not compatible with Node.js version 20.17.0.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 77.6 MB 77.6 MB 0 B -1 0%
initSize 146 MB 146 MB 0 B -0.98 0%
diffSize 68.5 MB 68.5 MB 0 B 1.04 0%
buildSize 6.82 MB 6.82 MB 0 B -0.53 0%
buildSbAddonsSize 1.5 MB 1.5 MB 0 B -0.64 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 1.85 MB 1.85 MB 0 B 0.99 0%
buildSbPreviewSize 271 kB 271 kB 0 B 0.99 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 3.82 MB 3.82 MB 0 B -0.54 0%
buildPreviewSize 3 MB 3 MB 0 B 0.74 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 5.8s 17.6s 11.7s 0.64 66.8%
generateTime 20.9s 20.4s -494ms -0.99 -2.4%
initTime 14.6s 13.3s -1s -328ms -1.06 -9.9%
buildTime 8s 9.4s 1.3s 0.09 14.7%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 6.5s 6.3s -184ms -0.11 -2.9%
devManagerResponsive 4.5s 4.3s -195ms 0.01 -4.5%
devManagerHeaderVisible 550ms 519ms -31ms -0.67 -6%
devManagerIndexVisible 630ms 575ms -55ms -0.48 -9.6%
devStoryVisibleUncached 1.1s 958ms -199ms -0.35 -20.8%
devStoryVisible 583ms 547ms -36ms -0.71 -6.6%
devAutodocsVisible 498ms 423ms -75ms -1.23 -17.7%
devMDXVisible 565ms 431ms -134ms -0.98 -31.1%
buildManagerHeaderVisible 555ms 496ms -59ms -0.63 -11.9%
buildManagerIndexVisible 573ms 507ms -66ms -0.78 -13%
buildStoryVisible 554ms 495ms -59ms -1.26 🔰-11.9%
buildAutodocsVisible 484ms 387ms -97ms -1.44 🔰-25.1%
buildMDXVisible 436ms 389ms -47ms -1.38 🔰-12.1%

Greptile Summary

This PR updates the sass-loader package in the Next.js framework to improve compatibility with newer Node.js versions.

  • Updated sass-loader from ^13.2.0 to ^14.2.1 in /code/frameworks/nextjs/package.json
  • Addresses compatibility issues with Node.js version 20.17.0
  • Removes dependency on the fibers package, which was not compatible with Node.js 20.17.0
  • Ensures better support for recent Node.js versions in Storybook's Next.js framework

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

nx-cloud bot commented Oct 2, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6d78a22. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@valentinpalkovic valentinpalkovic merged commit bc837ac into storybookjs:next Nov 1, 2024
55 checks passed
@github-actions github-actions bot mentioned this pull request Nov 1, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants