Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support .vue extention resolving #2896

Merged
merged 3 commits into from
Feb 9, 2018

Conversation

kazupon
Copy link
Member

@kazupon kazupon commented Feb 1, 2018

Issue:
In Vue projects, Cannot import single file components (.vue) without extension.

What I did

add .vue extention to resolve.extensions of webpack config.

How to test

Is this testable with jest or storyshots?
No

Does this need a new example in the kitchen sink apps?
No

Does this need an update to the documentation?
No

If your answer is yes to any of these, please make sure to include it in your PR.

@kazupon kazupon added the vue label Feb 1, 2018
@codecov
Copy link

codecov bot commented Feb 1, 2018

Codecov Report

Merging #2896 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2896   +/-   ##
=======================================
  Coverage   37.37%   37.37%           
=======================================
  Files         426      426           
  Lines        9151     9151           
  Branches      871      871           
=======================================
  Hits         3420     3420           
- Misses       5196     5197    +1     
+ Partials      535      534    -1
Impacted Files Coverage Δ
app/vue/src/server/config/webpack.config.prod.js 0% <ø> (ø) ⬆️
app/vue/src/server/config/webpack.config.js 0% <ø> (ø) ⬆️
app/polymer/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/polymer/src/server/babel_config.js 0% <0%> (-76.67%) ⬇️
addons/storyshots/src/react/renderShallowTree.js 57.14% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/shortcuts_help.js 25% <0%> (ø) ⬆️
.../ui/components/stories_panel/stories_tree/index.js 38.73% <0%> (ø) ⬆️
lib/core/src/client/preview/story_store.js 84.21% <0%> (ø) ⬆️
...ddons/actions/src/containers/ActionLogger/index.js 49.25% <0%> (ø) ⬆️
...i/src/modules/ui/components/stories_panel/index.js 20.96% <0%> (ø) ⬆️
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f56358...10792b7. Read the comment docs.

@igor-dv igor-dv merged commit 9881aed into storybookjs:master Feb 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants