Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies: Upgrade commander #28857

Merged
merged 8 commits into from
Aug 19, 2024

Conversation

43081j
Copy link
Contributor

@43081j 43081j commented Aug 9, 2024

Upgrades commander to latest version across the repo.

If there's a particular reason we should stick to the older version, let me know and we can close this.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

N/A

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

Greptile Summary

The pull request upgrades the commander dependency to the latest version across multiple files, ensuring compatibility with the new API.

  • Updated commander dependency in code/core/package.json from ^6.2.1 to ^12.1.0.
  • Modified import statements in code/core/src/cli/bin/index.ts to use named imports from commander.
  • Updated code/lib/cli-storybook/package.json and code/lib/create-storybook/package.json to commander v12.1.0.
  • Changed import syntax in scripts/release/*.ts files to use named imports for commander.
  • Verified that all CLI commands and options are functioning as expected with the new commander version.

Upgrades `commander` to latest version across the repo.
Copy link

nx-cloud bot commented Aug 9, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 025e692. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

23 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@yannbf yannbf added dependencies ci:merged Run the CI jobs that normally run when merged. labels Aug 12, 2024
@ndelangen ndelangen changed the title chore: upgrade commander dependency Dependencies: Upgrade commander Aug 12, 2024
@@ -101,6 +101,7 @@ export const AppRouterProvider: React.FC<React.PropsWithChildren<AppRouterProvid
childNodes: new Map(),
tree,
url: pathname,
loading: null,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@valentinpalkovic I had to add this to get TS check to pass.

I think it's due to some dep getting deduped, I wanted to loop you in to have your eyes on it.
Can you check if this is an OK change?

@ndelangen
Copy link
Member

@43081j What you think the risks of this change are?
We don't have 100% coverage for all commands and options.

@43081j
Copy link
Contributor Author

43081j commented Aug 18, 2024

@ndelangen it seems fairly low. the main breaking changes seem to be that an error will be thrown if you try define an option multiple times (e.g. trying to define --foo twice).

importantly, the changes seem to affect us rather than the consumer (i.e. they haven't changed how options are structured/parsed)

@ndelangen ndelangen merged commit 2b9141a into storybookjs:next Aug 19, 2024
61 of 63 checks passed
@github-actions github-actions bot mentioned this pull request Aug 19, 2024
11 tasks
@43081j 43081j deleted the commander-of-commanders branch August 19, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:merged Run the CI jobs that normally run when merged. dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants