Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #27210
What I did
globals
annotationChecklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Add a globals story, run with
STORYBOOK_TELEMETRY_DEBUG=1
, and verify that the story is logged inpayload.stats
.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>
Greptile Summary
The pull request adds telemetry tracking for the new
globals
annotation, including updates to tests and documentation.code/core/src/core-server/utils/StoryIndexGenerator.test.ts
: Addedglobals
field tostats
object in test cases to trackglobals
annotation usage.code/core/src/csf-tools/CsfFile.test.ts
: Updated test cases to include checks forglobals
property in story statistics.code/core/src/csf-tools/CsfFile.ts
: Includedglobals
in the list of tracked annotations in the__stats
object.code/core/src/types/modules/indexer.ts
: Addedglobals
property toIndexInputStats
interface for telemetry purposes.docs/configure/telemetry.mdx
: Documented new telemetry data collection forglobals
annotation.