Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-actions: Only log spies with names #28091

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

kasperpeulen
Copy link
Contributor

Closes #27534

What I did

Only log spies with names, see issue

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Copy link

nx-cloud bot commented Jun 6, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 94d1bbd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@kasperpeulen kasperpeulen requested a review from shilman June 6, 2024 15:18
@shilman shilman changed the title Addon-action: Only log spies with names Addon-actions: Only log spies with names Jun 6, 2024
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kasperpeulen !

@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jun 6, 2024
@shilman shilman merged commit 615d0d1 into next Jun 6, 2024
63 of 65 checks passed
@shilman shilman deleted the kasper/only-log-spies-with-names branch June 6, 2024 16:42
@github-actions github-actions bot mentioned this pull request Jun 6, 2024
13 tasks
storybook-bot pushed a commit that referenced this pull request Jun 6, 2024
…-names

Addon-actions: Only log spies with names
(cherry picked from commit 615d0d1)
@github-actions github-actions bot mentioned this pull request Jun 6, 2024
6 tasks
storybook-bot pushed a commit that referenced this pull request Jun 6, 2024
…-names

Addon-actions: Only log spies with names
(cherry picked from commit 615d0d1)
storybook-bot pushed a commit that referenced this pull request Jun 7, 2024
…-names

Addon-actions: Only log spies with names
(cherry picked from commit 615d0d1)
storybook-bot pushed a commit that referenced this pull request Jun 8, 2024
…-names

Addon-actions: Only log spies with names
(cherry picked from commit 615d0d1)
storybook-bot pushed a commit that referenced this pull request Jun 9, 2024
…-names

Addon-actions: Only log spies with names
(cherry picked from commit 615d0d1)
storybook-bot pushed a commit that referenced this pull request Jun 9, 2024
…-names

Addon-actions: Only log spies with names
(cherry picked from commit 615d0d1)
storybook-bot pushed a commit that referenced this pull request Jun 9, 2024
…-names

Addon-actions: Only log spies with names
(cherry picked from commit 615d0d1)
storybook-bot pushed a commit that referenced this pull request Jun 10, 2024
…-names

Addon-actions: Only log spies with names
(cherry picked from commit 615d0d1)
storybook-bot pushed a commit that referenced this pull request Jun 10, 2024
…-names

Addon-actions: Only log spies with names
(cherry picked from commit 615d0d1)
storybook-bot pushed a commit that referenced this pull request Jun 10, 2024
…-names

Addon-actions: Only log spies with names
(cherry picked from commit 615d0d1)
storybook-bot pushed a commit that referenced this pull request Jun 10, 2024
…-names

Addon-actions: Only log spies with names
(cherry picked from commit 615d0d1)
storybook-bot pushed a commit that referenced this pull request Jun 10, 2024
…-names

Addon-actions: Only log spies with names
(cherry picked from commit 615d0d1)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 12, 2024
@valentinpalkovic valentinpalkovic added the needs qa Indicates that this needs manual QA during the upcoming minor/major release label Jul 5, 2024
@ghengeveld ghengeveld removed the needs qa Indicates that this needs manual QA during the upcoming minor/major release label Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:normal patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: All fn() stubs get logged in the Actions panel, not just the component's args
4 participants