Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency: Update globby dependency #26733

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Apr 4, 2024

Closes N/A

What I did

I have updated the globby dependency. Since it is a pure ESM module, i have changed the import to a dynamic import.

Breaking changes of globby since version 11:

  • Require Node.js 18
  • This package is now pure ESM
  • This package now uses named exports instead of a default export
    • globby{globby}
    • globby.sync{globbySync}
    • globby.stream{globbyStream}
    • globby.generateGlobTasks{generateGlobTasks}
    • globby.hasMagic{isDynamicPattern}
    • globby.gitignore{isGitIgnored}
    • globby.gitignore.sync{isGitIgnoredSync}
  • Rename generateGlobTasks to generateGlobTasksSync
  • Remove ignore option for isGitIgnored and isGitIgnoredSync

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@valentinpalkovic valentinpalkovic self-assigned this Apr 4, 2024
@valentinpalkovic valentinpalkovic added dependencies ci:daily Run the CI jobs that normally run in the daily job. labels Apr 4, 2024
Copy link

nx-cloud bot commented Apr 4, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1b5acd2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@valentinpalkovic valentinpalkovic marked this pull request as ready for review April 4, 2024 09:51
@valentinpalkovic valentinpalkovic merged commit e73525b into next Apr 4, 2024
109 of 116 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/update-globby branch April 4, 2024 10:58
@github-actions github-actions bot mentioned this pull request Apr 4, 2024
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:daily Run the CI jobs that normally run in the daily job. dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants