Controls: Fix type summary when table.type unset #26283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
added
bug
patch:yes
|
@ndelangen I haven't tested the cases reported in that issue. It fixes the bug we looked at together yesterday, but that may or may not fix the bigger problem. I can take a closer look this weekend. |
|
OK, you might want to use both reproductions in the issue, they seem related, but are different. I suspect the second one has a completely different cause. |
|
@ndelangen I commented on the cause of the second issue. Self-merging this PR which fixes a bug, possibly not related to either of the issues in the linked issue. |
shilman
changed the title
17 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Mar 3, 2024
…summary Controls: Fix type summary when table.type unset (cherry picked from commit f0beb18)
Closed
8 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Mar 4, 2024
…summary Controls: Fix type summary when table.type unset (cherry picked from commit f0beb18)
storybook-bot
pushed a commit
that referenced
this pull request
Mar 4, 2024
…summary Controls: Fix type summary when table.type unset (cherry picked from commit f0beb18)
storybook-bot
pushed a commit
that referenced
this pull request
Mar 4, 2024
…summary Controls: Fix type summary when table.type unset (cherry picked from commit f0beb18)
storybook-bot
pushed a commit
that referenced
this pull request
Mar 4, 2024
…summary Controls: Fix type summary when table.type unset (cherry picked from commit f0beb18)
storybook-bot
pushed a commit
that referenced
this pull request
Mar 4, 2024
…summary Controls: Fix type summary when table.type unset (cherry picked from commit f0beb18)
storybook-bot
pushed a commit
that referenced
this pull request
Mar 4, 2024
…summary Controls: Fix type summary when table.type unset (cherry picked from commit f0beb18)
storybook-bot
pushed a commit
that referenced
this pull request
Mar 4, 2024
…summary Controls: Fix type summary when table.type unset (cherry picked from commit f0beb18)
storybook-bot
pushed a commit
that referenced
this pull request
Mar 4, 2024
…summary Controls: Fix type summary when table.type unset (cherry picked from commit f0beb18)
storybook-bot
pushed a commit
that referenced
this pull request
Mar 5, 2024
…summary Controls: Fix type summary when table.type unset (cherry picked from commit f0beb18)
storybook-bot
pushed a commit
that referenced
this pull request
Mar 5, 2024
…summary Controls: Fix type summary when table.type unset (cherry picked from commit f0beb18)
storybook-bot
pushed a commit
that referenced
this pull request
Mar 10, 2024
…summary Controls: Fix type summary when table.type unset (cherry picked from commit f0beb18)
storybook-bot
pushed a commit
that referenced
this pull request
Mar 11, 2024
…summary Controls: Fix type summary when table.type unset (cherry picked from commit f0beb18)
storybook-bot
pushed a commit
that referenced
this pull request
Mar 11, 2024
…summary Controls: Fix type summary when table.type unset (cherry picked from commit f0beb18)
storybook-bot
pushed a commit
that referenced
this pull request
Mar 11, 2024
…summary Controls: Fix type summary when table.type unset (cherry picked from commit f0beb18)
storybook-bot
pushed a commit
that referenced
this pull request
Mar 11, 2024
…summary Controls: Fix type summary when table.type unset (cherry picked from commit f0beb18)
storybook-bot
pushed a commit
that referenced
this pull request
Mar 11, 2024
…summary Controls: Fix type summary when table.type unset (cherry picked from commit f0beb18)
storybook-bot
pushed a commit
that referenced
this pull request
Mar 11, 2024
…summary Controls: Fix type summary when table.type unset (cherry picked from commit f0beb18)
storybook-bot
pushed a commit
that referenced
this pull request
Mar 12, 2024
…summary Controls: Fix type summary when table.type unset (cherry picked from commit f0beb18)
Merged
11 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Mar 12, 2024
…summary Controls: Fix type summary when table.type unset (cherry picked from commit f0beb18)
storybook-bot
pushed a commit
that referenced
this pull request
Mar 12, 2024
…summary Controls: Fix type summary when table.type unset (cherry picked from commit f0beb18)
storybook-bot
pushed a commit
that referenced
this pull request
Mar 12, 2024
…summary Controls: Fix type summary when table.type unset (cherry picked from commit f0beb18)
storybook-bot
pushed a commit
that referenced
this pull request
Mar 12, 2024
…summary Controls: Fix type summary when table.type unset (cherry picked from commit f0beb18)
storybook-bot
pushed a commit
that referenced
this pull request
Mar 12, 2024
…summary Controls: Fix type summary when table.type unset (cherry picked from commit f0beb18)
storybook-bot
pushed a commit
that referenced
this pull request
Mar 12, 2024
…summary Controls: Fix type summary when table.type unset (cherry picked from commit f0beb18)
storybook-bot
pushed a commit
that referenced
this pull request
Mar 13, 2024
…summary Controls: Fix type summary when table.type unset (cherry picked from commit f0beb18)
storybook-bot
pushed a commit
that referenced
this pull request
Mar 13, 2024
…summary Controls: Fix type summary when table.type unset (cherry picked from commit f0beb18)
storybook-bot
pushed a commit
that referenced
this pull request
Mar 13, 2024
…summary Controls: Fix type summary when table.type unset (cherry picked from commit f0beb18)
storybook-bot
pushed a commit
that referenced
this pull request
Mar 13, 2024
…summary Controls: Fix type summary when table.type unset (cherry picked from commit f0beb18)
storybook-bot
pushed a commit
that referenced
this pull request
Mar 13, 2024
…summary Controls: Fix type summary when table.type unset (cherry picked from commit f0beb18)
storybook-bot
pushed a commit
that referenced
this pull request
Mar 13, 2024
…summary Controls: Fix type summary when table.type unset (cherry picked from commit f0beb18)
storybook-bot
pushed a commit
that referenced
this pull request
Mar 14, 2024
…summary Controls: Fix type summary when table.type unset (cherry picked from commit f0beb18)
storybook-bot
pushed a commit
that referenced
this pull request
Mar 14, 2024
…summary Controls: Fix type summary when table.type unset (cherry picked from commit f0beb18)
storybook-bot
pushed a commit
that referenced
this pull request
Mar 15, 2024
…summary Controls: Fix type summary when table.type unset (cherry picked from commit f0beb18)
storybook-bot
pushed a commit
that referenced
this pull request
Mar 15, 2024
…summary Controls: Fix type summary when table.type unset (cherry picked from commit f0beb18)
storybook-bot
pushed a commit
that referenced
this pull request
Mar 16, 2024
…summary Controls: Fix type summary when table.type unset (cherry picked from commit f0beb18)
storybook-bot
pushed a commit
that referenced
this pull request
Mar 17, 2024
…summary Controls: Fix type summary when table.type unset (cherry picked from commit f0beb18)
storybook-bot
pushed a commit
that referenced
this pull request
Mar 17, 2024
…summary Controls: Fix type summary when table.type unset (cherry picked from commit f0beb18)
storybook-bot
pushed a commit
that referenced
this pull request
Mar 17, 2024
…summary Controls: Fix type summary when table.type unset (cherry picked from commit f0beb18)
github-actions
bot
added
the
patch:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #25909
What I did
When the user specifies a
typebut there is notable.typeannotation generated, display this correctly in the ArgRow componentsChecklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
See the Chromatic changes for the
ArgRowstories🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>