Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add angular framework doc #26269

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Docs: Add angular framework doc #26269

merged 3 commits into from
Mar 8, 2024

Conversation

kylegach
Copy link
Contributor

Closes #22289

What I did

See title

screenshot of docs page

Checklist for Contributors

Testing

Manual testing

  1. Follow the steps in the contributing instructions for this branch, framework-doc-angular

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@kylegach kylegach added documentation ci:docs Run the CI jobs for documentation checks only. labels Feb 29, 2024
@kylegach kylegach self-assigned this Feb 29, 2024
@kylegach kylegach force-pushed the framework-doc-angular branch from c7c543c to 95a3e8b Compare February 29, 2024 23:49
@kylegach kylegach changed the title Add angular framework doc Docs: Add angular framework doc Mar 1, 2024
@kylegach kylegach force-pushed the framework-doc-angular branch from 95a3e8b to 70c5ed3 Compare March 5, 2024 20:11
@kylegach kylegach force-pushed the framework-doc-angular branch from 70c5ed3 to e76e062 Compare March 6, 2024 20:31
Copy link

nx-cloud bot commented Mar 6, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0702351. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@valentinpalkovic
Copy link
Contributor

Left a small comment. Otherwise LGTM! Great job <3

@kylegach kylegach merged commit 0b2b5ff into next Mar 8, 2024
16 checks passed
@kylegach kylegach deleted the framework-doc-angular branch March 8, 2024 17:17
@github-actions github-actions bot mentioned this pull request Mar 8, 2024
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:docs Run the CI jobs for documentation checks only. documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Documentation]: API docs for componentWrapperDecorator and moduleMetadata
2 participants