-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI: Add webpack5 compiler automigration #26000
Merged
valentinpalkovic
merged 24 commits into
next
from
valentin/add-webpack5-compiler-automigration
Feb 19, 2024
Merged
CLI: Add webpack5 compiler automigration #26000
valentinpalkovic
merged 24 commits into
next
from
valentin/add-webpack5-compiler-automigration
Feb 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-compiler-automigration
valentinpalkovic
changed the title
Valentin/add webpack5 compiler automigration
Automigration: Add webpack5 compiler automigration
Feb 12, 2024
This comment was marked as resolved.
This comment was marked as resolved.
valentinpalkovic
force-pushed
the
valentin/add-webpack5-compiler-automigration
branch
from
February 16, 2024 14:31
34f05f8
to
6261cdf
Compare
shilman
reviewed
Feb 19, 2024
shilman
requested changes
Feb 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be a TS error no?
shilman
approved these changes
Feb 19, 2024
valentinpalkovic
deleted the
valentin/add-webpack5-compiler-automigration
branch
February 19, 2024 11:02
26 tasks
shilman
changed the title
Automigration: Add webpack5 compiler automigration
CLI: Add webpack5 compiler automigration
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25431
What I did
This PR adds an automigration for Webpack5 users to
a) remove the
framework.options.builder.useSWC
flagb) set up either
@storybook/addon-webpack5-compiler-swc
or@storybook/addon-webpack5-compiler-babel
to add a compiler to the Webpack5 builderc) changed
promptOnly
prop in fixes topromptType
to allow different prompt types. Now,manual
,auto
andnotified
can be used.The frameworks
@storybook/angular
,@storybook/nextjs
,@storybook/react-webpack5 in combination with CRA
and@storybook/ember
do not need an additional compiler addon, since they have their compilers built-in.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
The auto migration is skipped in the following scenarios:
core.builder
)The auto migration should do the following things:
framework.options.builder.useSWC
is set, it should be removedNext.js specific:
Except Next.js:
framework.options.builder.useSWC === true
, the@storybook/addon-webpack5-compiler-swc
will be installed and added to theaddons
section of the main configuration file.framework.options.builder.useSWC === false | undefined
, a prompt appears to ask the user, whether the babel or swc addon should be installedTest Results
Test Candidate: https://github.com/nodejs/nodejs.org (Next.js)
framework.options.builder.useSWC
gets removed when setTest Candidate: https://github.com/bitwarden/clients (Angular)
Test Candidate: Fresh CRA project on SB7 (CRA)
Test Candidate: Storybook react-webpack5 sandbox (React)
framework.options.builder.useSWC
is set to false or not set at alladdons
section of.storybook/main.js
. A prompt notifies the user about these actions.Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-26000-sha-e0e439e7
. Try it out in a new sandbox by runningnpx [email protected] sandbox
or in an existing project withnpx [email protected] upgrade
.More information
0.0.0-pr-26000-sha-e0e439e7
valentin/add-webpack5-compiler-automigration
e0e439e7
1708331635
)To request a new release of this pull request, mention the
@storybookjs/core
team.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=26000