Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sandboxes: Update wait-on command to use TCP instead of HTTP #25541

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Jan 10, 2024

Relates to jeffbski/wait-on#133

What I did

Currently, it is not possible to run E2E tests locally. It also seems that CI sometimes takes pretty long to continue, and it waits for more than 10 minutes before actually the E2E tests are executed. It seems that the library wait-on currently has a bug, where it is not able to properly await a server if it is given as, e.g., http://localhost:PORT. Only tcp:127.0.0.1:PORT seems to work.

Checklist for Contributors

Testing

  • Run E2E tests locally in a Node.js 18 environment. They should work appropriately. (e.g. yarn task --task e2e-tests --template lit-vite/default-ts --no-link --junit)

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@valentinpalkovic valentinpalkovic changed the title Update wait-on command to use TCP instead of HTTP Sandboxes: Update wait-on command to use TCP instead of HTTP Jan 10, 2024
@valentinpalkovic valentinpalkovic self-assigned this Jan 10, 2024
@valentinpalkovic valentinpalkovic merged commit e95e2b9 into next Jan 16, 2024
63 of 68 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/fix-wait-on-locally branch January 16, 2024 14:30
@github-actions github-actions bot mentioned this pull request Jan 17, 2024
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants