Core: Remove vite plugins and drop Vite 3 support #25427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperpeulen
requested review from
yannbf,
JReinhold,
valentinpalkovic and
IanVS
as code owners
kasperpeulen
changed the title
This was referenced Jan 3, 2024
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
Migration notes are missing. Otherwise LGTM |
… kasper/remove-vite-plugins
|
@kasperpeulen Do you want us to test something explicitly? |
Co-authored-by: Valentin Palkovic <[email protected]>
Co-authored-by: Valentin Palkovic <[email protected]>
|
@valentinpalkovic I don't think it is neccesary TBH. I did some manual testing on svelte and react, which was fine. I think problem with those changes should also be covered extensively in automated testing. |
valentinpalkovic
approved these changes
Jan 3, 2024
yannbf
reviewed
Jan 3, 2024
| @@ -336,6 +337,21 @@ | |||
|
|
|||
| ## From version 7.x to 8.0.0 | |||
|
|
|||
| ### Framework-specific Vite plugins have to be explicitly added | |||
There was a problem hiding this comment.
Please add a note for Dropped Vite 3 support
yannbf
reviewed
Jan 3, 2024
| "@types/node": "^18.0.0", | ||
| "svelte": "^5.0.0-next.16", | ||
| "typescript": "^5.3.2", | ||
| "vite": "^4.0.0" | ||
| }, | ||
| "peerDependencies": { | ||
| "@sveltejs/vite-plugin-svelte": "^2.0.0 || ^3.0.0", |
There was a problem hiding this comment.
You removed the plugin for react but added the one for svelte?
15 tasks
|
Can I ask, why is it necessary to drop support for Vite 3? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #25127
Closes #25427
What I did
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>