Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Fix regex used in upgrade command #25284

Merged
merged 2 commits into from
Jan 3, 2024
Merged

CLI: Fix regex used in upgrade command #25284

merged 2 commits into from
Jan 3, 2024

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Dec 20, 2023

Closes #

What I did

When running npx storybook@next upgrade --prerelease, the reject flag passed onto npm-check-updates was incorrect, resulting in an unsuccessful upgrade. However, the code didn't handle the error state, and therefore the upgrade command would continue:

This PR both fixes the regex and adds categorized errors to the upgrade CLI command:

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

No need, it's been thoroughly tested.

  1. Open a Storybook project
  2. run path/to/cli/bin/index.js upgrade --prerelease
  3. it should succeed

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@yannbf yannbf force-pushed the fix/upgrade-command branch from 5bdf988 to 6b5d9c7 Compare December 21, 2023 12:24
@yannbf yannbf merged commit 570636b into next Jan 3, 2024
54 of 57 checks passed
@yannbf yannbf deleted the fix/upgrade-command branch January 3, 2024 19:16
@github-actions github-actions bot mentioned this pull request Jan 3, 2024
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants