-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: New icon library #24433
UI: New icon library #24433
Conversation
There is a 3% increase in static build size from this change (8.615e6 bytes vs 8.378e6). This is small enough that we can probably disregard it and bring the size down in other ways. cc @ndelangen @JReinhold @vanessayuenn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall great work!
My comments are only minor things here and there.
No top level dependency changes detected. Learn more about Socket for GitHub ↗︎ |
What I did
Storybook has a new icon library that is used across our entire set of products available here. In this PR we are replacing the old icon library set in
@storybook/components
in favour of@storybook/icons
.The transition is made in 2 steps. First in 8.0:
Icons
andSymbols
components.Icons
andSymbols
components.@storybook/icons
and use it under the hood on theIcons
andSymbols
components.Icons
andSymbols
components in the monorepo.In 9.0 we will:
Icons
component, making use of the full tree-shaking of the new@storybook/icons
library.Symbols
componentTodo:
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>