Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Throw an error when critical presets fail to load #24176

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Sep 14, 2023

Relates to #24071

What I did

Many users are having issues that say "No builder configured" which are cryptic, because it might mean something else is broken, and the "No builder configured" message is just a red herring. This PR will make sure that before we try to access a Storybook builder, if there is a failure when loading presets, it will result in a crash instead of warnings. This should help us and users to understand what is happening.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

  1. Run a sandbox for nextjs, e.g. yarn task --task sandbox --start-from auto --template nextjs/default-ts
  2. Uninstall next
  3. Run Storybook dev

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@yannbf yannbf added bug patch:yes Bugfix & documentation PR that need to be picked to main branch core ci:normal labels Sep 14, 2023
@yannbf yannbf merged commit 0b5dc9a into next Sep 15, 2023
15 of 17 checks passed
@yannbf yannbf deleted the yann/critical-preset-error branch September 15, 2023 08:30
@yannbf yannbf removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants