CLI: Fix packageManager handling in sb add
#24079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaunEvening
requested review from
yannbf,
valentinpalkovic and
ndelangen
as code owners
shilman
changed the title
sb add
ndelangen
approved these changes
Sep 5, 2023
25 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Sep 6, 2023
CLI: Fix packageManager handling in `sb add` (cherry picked from commit 0cb9932)
Merged
10 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Sep 6, 2023
CLI: Fix packageManager handling in `sb add` (cherry picked from commit 0cb9932)
storybook-bot
pushed a commit
that referenced
this pull request
Sep 7, 2023
CLI: Fix packageManager handling in `sb add` (cherry picked from commit 0cb9932)
storybook-bot
pushed a commit
that referenced
this pull request
Sep 8, 2023
CLI: Fix packageManager handling in `sb add` (cherry picked from commit 0cb9932)
storybook-bot
pushed a commit
that referenced
this pull request
Sep 8, 2023
CLI: Fix packageManager handling in `sb add` (cherry picked from commit 0cb9932)
storybook-bot
pushed a commit
that referenced
this pull request
Sep 8, 2023
CLI: Fix packageManager handling in `sb add` (cherry picked from commit 0cb9932)
github-actions
bot
added
the
patch:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes storybookjs/addon-styling-webpack#2
What I did
typefromPackageManagerclass to set manager for postinstallyarn1Checklist for Contributors
Testing
add @storybook/addon-styling-webpackwith local CLIChecklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>