Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon API: Improve the updateStatus API #24007

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Aug 30, 2023

What I did

  • add ability to remove via setting null
  • add ability to update status via a state-setter-function

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

No manual tests are needed

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts
  • [x Make sure this PR contains one of the labels below

🦋 Canary release

This pull request has been released as version 0.0.0-pr-24007-sha-c31c498a. Install it by pinning all your Storybook dependencies to that version.

More information
Published version 0.0.0-pr-24007-sha-c31c498a
Triggered by @ndelangen
Repository storybookjs/storybook
Branch norbert/enhance-updateStatus
Commit c31c498a
Datetime Wed Aug 30 09:48:37 UTC 2023 (1693388917)
Workflow run 6023282677

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=24007

add ability to update status via a state-setter-function
@ndelangen ndelangen self-assigned this Aug 30, 2023
@ndelangen ndelangen requested a review from tmeasday August 30, 2023 09:47
@ndelangen ndelangen changed the title Addon API: improve the updateStatus API Addon API: Improve the updateStatus API Aug 30, 2023
@ndelangen ndelangen requested a review from ghengeveld August 30, 2023 10:24
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ndelangen ndelangen merged commit 115d439 into next Aug 31, 2023
@ndelangen ndelangen deleted the norbert/enhance-updateStatus branch August 31, 2023 10:12
@ndelangen ndelangen added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Sep 13, 2023
storybook-bot pushed a commit that referenced this pull request Sep 14, 2023
Addon API: Improve the updateStatus API

(cherry picked from commit 115d439)
@github-actions github-actions bot mentioned this pull request Sep 14, 2023
6 tasks
storybook-bot pushed a commit that referenced this pull request Sep 14, 2023
Addon API: Improve the updateStatus API

(cherry picked from commit 115d439)
storybook-bot pushed a commit that referenced this pull request Sep 14, 2023
Addon API: Improve the updateStatus API

(cherry picked from commit 115d439)
@ndelangen ndelangen added maintenance User-facing maintenance tasks and removed feature request labels Sep 14, 2023
storybook-bot pushed a commit that referenced this pull request Sep 14, 2023
Addon API: Improve the updateStatus API

(cherry picked from commit 115d439)
storybook-bot pushed a commit that referenced this pull request Sep 14, 2023
Addon API: Improve the updateStatus API

(cherry picked from commit 115d439)
storybook-bot pushed a commit that referenced this pull request Sep 15, 2023
Addon API: Improve the updateStatus API

(cherry picked from commit 115d439)
storybook-bot pushed a commit that referenced this pull request Sep 15, 2023
Addon API: Improve the updateStatus API

(cherry picked from commit 115d439)
storybook-bot pushed a commit that referenced this pull request Sep 15, 2023
Addon API: Improve the updateStatus API

(cherry picked from commit 115d439)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: addons ci:normal maintenance User-facing maintenance tasks patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants