-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon API: Improve the updateStatus API #24007
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add ability to update status via a state-setter-function
ndelangen
requested review from
kasperpeulen and
valentinpalkovic
as code owners
August 30, 2023 09:45
ndelangen
changed the title
Addon API: improve the updateStatus API
Addon API: Improve the updateStatus API
Aug 30, 2023
tmeasday
approved these changes
Aug 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
15 tasks
ndelangen
added
the
patch:yes
Bugfix & documentation PR that need to be picked to main branch
label
Sep 13, 2023
storybook-bot
pushed a commit
that referenced
this pull request
Sep 14, 2023
Addon API: Improve the updateStatus API (cherry picked from commit 115d439)
Merged
6 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Sep 14, 2023
Addon API: Improve the updateStatus API (cherry picked from commit 115d439)
storybook-bot
pushed a commit
that referenced
this pull request
Sep 14, 2023
Addon API: Improve the updateStatus API (cherry picked from commit 115d439)
ndelangen
added
maintenance
User-facing maintenance tasks
and removed
feature request
labels
Sep 14, 2023
storybook-bot
pushed a commit
that referenced
this pull request
Sep 14, 2023
Addon API: Improve the updateStatus API (cherry picked from commit 115d439)
storybook-bot
pushed a commit
that referenced
this pull request
Sep 14, 2023
Addon API: Improve the updateStatus API (cherry picked from commit 115d439)
storybook-bot
pushed a commit
that referenced
this pull request
Sep 15, 2023
Addon API: Improve the updateStatus API (cherry picked from commit 115d439)
storybook-bot
pushed a commit
that referenced
this pull request
Sep 15, 2023
Addon API: Improve the updateStatus API (cherry picked from commit 115d439)
storybook-bot
pushed a commit
that referenced
this pull request
Sep 15, 2023
Addon API: Improve the updateStatus API (cherry picked from commit 115d439)
github-actions
bot
added
the
patch:done
Patch/release PRs already cherry-picked to main/release branch
label
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: addons
ci:normal
maintenance
User-facing maintenance tasks
patch:done
Patch/release PRs already cherry-picked to main/release branch
patch:yes
Bugfix & documentation PR that need to be picked to main branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
null
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
No manual tests are needed
Documentation
MIGRATION.MD
Checklist for Maintainers
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
🦋 Canary release
This pull request has been released as version
0.0.0-pr-24007-sha-c31c498a
. Install it by pinning all your Storybook dependencies to that version.More information
0.0.0-pr-24007-sha-c31c498a
norbert/enhance-updateStatus
c31c498a
1693388917
)To request a new release of this pull request, mention the
@storybookjs/core
team.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=24007