Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logger: Fix double error messages/stack #23919

Merged
merged 6 commits into from
Aug 23, 2023

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Aug 22, 2023

What I did

Before:
Screenshot 2023-08-22 at 20 16 17

After:
Screenshot 2023-08-22 at 20 16 43

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

  1. Break the build/dev somehow that would normally break storybook. I opted to breaking the manager builder.
     export const executor = {
       get: async () => {
         const { build } = await import('esbuild');
         // return build;
    
         return undefined;
       },
     };
  2. run any sandbox or the ui storybook
  3. expect the error displayed in the console to only list the stack once!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@ndelangen ndelangen requested a review from yannbf as a code owner August 22, 2023 18:18
@yannbf
Copy link
Member

yannbf commented Aug 23, 2023

This is fantastic <3

On the matter of double messages, could you maybe take a look at webpack failures? They still log double error messages:
image

To reproduce:

  1. create a webpack sandbox
  2. add this to main config: webpackFinal: (config) => ({})

Totally fine if you don't want to do this or do it in a different PR

@ndelangen
Copy link
Member Author

@yannbf I think this is a quick win already, Let's not have "Perfect" be the enemy of "Good".

@ndelangen ndelangen requested a review from yannbf August 23, 2023 14:33
@ndelangen ndelangen merged commit 7830782 into next Aug 23, 2023
@ndelangen ndelangen deleted the norbert/improve-node-logger-error branch August 23, 2023 14:43
@github-actions github-actions bot mentioned this pull request Aug 23, 2023
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants