Nextjs: Improve support for Windows-style paths #23695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
T99
requested review from
valentinpalkovic,
kasperpeulen and
yannbf
as code owners
|
Hey @ndelangen would you mind checking this out whenever you have time? Thanks! It might take some time as we are quite busy, we really appreciate your efforts and patience <3 |
|
I do not have the capability to follow these manual testing steps, because I have no Windows based machine at my disposal. I find it impossible to judge the code-change by looking at the diff alone. |
|
Hey @T99, Well done and thank you for the provided fix! Tested on Windows and verified, whether it's still working in non-Windows environments |
valentinpalkovic
approved these changes
Oct 2, 2023
20 tasks
JReinhold
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added more portable path handling code to better support win32-style paths. Prior to this PR, attempting to use fonts via `next/font/local' in Storybook on a Windows machine would result in broken font resource paths.
Closes #21968
What I did
Added more portable path handling code to better support win32-style paths. As demonstrated by #21968, a bug existed with the current way that paths were being translated between
next/fontand Storybook. This PR utilizes more portable path handling logic and sanitizes win32-style paths to the Unix-style paths expected in standard web URIs.How to test
next/fonton a Windows-based machine.@font-facedeclarations that are generated into the story and ensure that the paths are correct, and that the fonts are being loaded and are available in the story.Checklist
MIGRATION.MD
Maintainers
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]