-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release tooling: Make canaries use v0.0.0
#23609
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JReinhold
added
patch:yes
Bugfix & documentation PR that need to be picked to main branch
build
Internal-facing build tooling & test updates
labels
Jul 26, 2023
vanessayuenn
approved these changes
Jul 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚢
JReinhold
changed the title
Release tooling: Canaries use
Release tooling: Make canaries use Jul 26, 2023
v0.0.0
v0.0.0
This was referenced Jul 26, 2023
Merged
Closed
storybook-bot
pushed a commit
that referenced
this pull request
Aug 3, 2023
Release tooling: Make canaries use `v0.0.0` (cherry picked from commit 5dcc66f)
Closed
32 tasks
storybook-bot
pushed a commit
that referenced
this pull request
Aug 4, 2023
Release tooling: Make canaries use `v0.0.0` (cherry picked from commit 5dcc66f)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
Release tooling: Make canaries use `v0.0.0` (cherry picked from commit 5dcc66f)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
Release tooling: Make canaries use `v0.0.0` (cherry picked from commit 5dcc66f)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
Release tooling: Make canaries use `v0.0.0` (cherry picked from commit 5dcc66f)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 7, 2023
Release tooling: Make canaries use `v0.0.0` (cherry picked from commit 5dcc66f)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 8, 2023
Release tooling: Make canaries use `v0.0.0` (cherry picked from commit 5dcc66f)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
Release tooling: Make canaries use `v0.0.0` (cherry picked from commit 5dcc66f)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
Release tooling: Make canaries use `v0.0.0` (cherry picked from commit 5dcc66f)
storybook-bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
Release tooling: Make canaries use `v0.0.0` (cherry picked from commit 5dcc66f)
kasperpeulen
removed
the
patch:yes
Bugfix & documentation PR that need to be picked to main branch
label
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
The current versioning for canary releases means that users specifying a prerelease dependency with a caret, eg.
@storybook/cli@^7.2.0-alpha.0
will end up getting a canary release for that, because npm treats the "c" in "canary" as later than the "a" in "alpha".This PR publishes canaries to
v0.0.0
to fix that.How to test
See the canary release of this PR at https://github.com/storybookjs/storybook/actions/runs/5666847429/job/15354420488
Checklist
MIGRATION.MD
Maintainers
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]
🦋 Canary release
This pull request has been released as version
0.0.0-pr-23609-sha-f47ef339
. Install it by pinning all your Storybook dependencies to that version.More information
0.0.0-pr-23609-sha-f47ef339
fix-canary-versions
f47ef339
1690362469
)To request a new release of this pull request, mention the
@storybookjs/core
team.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=23609