Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release tooling: Make canaries use v0.0.0 #23609

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Conversation

JReinhold
Copy link
Contributor

@JReinhold JReinhold commented Jul 26, 2023

What I did

The current versioning for canary releases means that users specifying a prerelease dependency with a caret, eg. @storybook/cli@^7.2.0-alpha.0 will end up getting a canary release for that, because npm treats the "c" in "canary" as later than the "a" in "alpha".
This PR publishes canaries to v0.0.0 to fix that.

How to test

See the canary release of this PR at https://github.com/storybookjs/storybook/actions/runs/5666847429/job/15354420488

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]

🦋 Canary release

This pull request has been released as version 0.0.0-pr-23609-sha-f47ef339. Install it by pinning all your Storybook dependencies to that version.

More information
Published version 0.0.0-pr-23609-sha-f47ef339
Triggered by @JReinhold
Repository storybookjs/storybook
Branch fix-canary-versions
Commit f47ef339
Datetime Wed Jul 26 09:07:49 UTC 2023 (1690362469)
Workflow run 5666847429

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=23609

@JReinhold JReinhold added patch:yes Bugfix & documentation PR that need to be picked to main branch build Internal-facing build tooling & test updates labels Jul 26, 2023
@JReinhold JReinhold temporarily deployed to release July 26, 2023 09:07 — with GitHub Actions Inactive
Copy link
Contributor

@vanessayuenn vanessayuenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@JReinhold JReinhold changed the title Release tooling: Canaries use v0.0.0 Release tooling: Make canaries use v0.0.0 Jul 26, 2023
@JReinhold JReinhold merged commit 5dcc66f into next Jul 26, 2023
@JReinhold JReinhold deleted the fix-canary-versions branch July 26, 2023 10:57
This was referenced Jul 26, 2023
storybook-bot pushed a commit that referenced this pull request Aug 3, 2023
Release tooling: Make canaries use `v0.0.0`

(cherry picked from commit 5dcc66f)
@github-actions github-actions bot mentioned this pull request Aug 3, 2023
32 tasks
storybook-bot pushed a commit that referenced this pull request Aug 4, 2023
Release tooling: Make canaries use `v0.0.0`

(cherry picked from commit 5dcc66f)
storybook-bot pushed a commit that referenced this pull request Aug 7, 2023
Release tooling: Make canaries use `v0.0.0`

(cherry picked from commit 5dcc66f)
storybook-bot pushed a commit that referenced this pull request Aug 7, 2023
Release tooling: Make canaries use `v0.0.0`

(cherry picked from commit 5dcc66f)
storybook-bot pushed a commit that referenced this pull request Aug 7, 2023
Release tooling: Make canaries use `v0.0.0`

(cherry picked from commit 5dcc66f)
storybook-bot pushed a commit that referenced this pull request Aug 7, 2023
Release tooling: Make canaries use `v0.0.0`

(cherry picked from commit 5dcc66f)
storybook-bot pushed a commit that referenced this pull request Aug 8, 2023
Release tooling: Make canaries use `v0.0.0`

(cherry picked from commit 5dcc66f)
storybook-bot pushed a commit that referenced this pull request Aug 9, 2023
Release tooling: Make canaries use `v0.0.0`

(cherry picked from commit 5dcc66f)
storybook-bot pushed a commit that referenced this pull request Aug 9, 2023
Release tooling: Make canaries use `v0.0.0`

(cherry picked from commit 5dcc66f)
storybook-bot pushed a commit that referenced this pull request Aug 9, 2023
Release tooling: Make canaries use `v0.0.0`

(cherry picked from commit 5dcc66f)
@kasperpeulen kasperpeulen removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:normal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants