Release tooling: Fix double run of publish workflow #23432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JReinhold
added
patch:yes
storybook-bot
pushed a commit
that referenced
this pull request
Jul 13, 2023
Release tooling: Fix double run of publish workflow (cherry picked from commit 4f1fe59)
This was referenced Jul 13, 2023
Closed
storybook-bot
pushed a commit
that referenced
this pull request
Jul 13, 2023
Release tooling: Fix double run of publish workflow (cherry picked from commit 4f1fe59)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 13, 2023
Release tooling: Fix double run of publish workflow (cherry picked from commit 4f1fe59)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 13, 2023
Release tooling: Fix double run of publish workflow (cherry picked from commit 4f1fe59)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 13, 2023
Release tooling: Fix double run of publish workflow (cherry picked from commit 4f1fe59)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 13, 2023
Release tooling: Fix double run of publish workflow (cherry picked from commit 4f1fe59)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 13, 2023
Release tooling: Fix double run of publish workflow (cherry picked from commit 4f1fe59)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 14, 2023
Release tooling: Fix double run of publish workflow (cherry picked from commit 4f1fe59)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 14, 2023
Release tooling: Fix double run of publish workflow (cherry picked from commit 4f1fe59)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 15, 2023
Release tooling: Fix double run of publish workflow (cherry picked from commit 4f1fe59)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 15, 2023
Release tooling: Fix double run of publish workflow (cherry picked from commit 4f1fe59)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 17, 2023
Release tooling: Fix double run of publish workflow (cherry picked from commit 4f1fe59)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 17, 2023
Release tooling: Fix double run of publish workflow (cherry picked from commit 4f1fe59)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 17, 2023
Release tooling: Fix double run of publish workflow (cherry picked from commit 4f1fe59)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 17, 2023
Release tooling: Fix double run of publish workflow (cherry picked from commit 4f1fe59)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 17, 2023
Release tooling: Fix double run of publish workflow (cherry picked from commit 4f1fe59)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 17, 2023
Release tooling: Fix double run of publish workflow (cherry picked from commit 4f1fe59)
storybook-bot
pushed a commit
that referenced
this pull request
Jul 18, 2023
Release tooling: Fix double run of publish workflow (cherry picked from commit 4f1fe59)
JReinhold
added
the
patch:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
#23393 introduced an "apply" step to the publishing workflow, that committed the version bump to
next-release/latest-release. This had the unfortunate side-effect that this commit would trigger a secondary run of the publish workflow, running simultaneously with the already running publish workflow (albeit a little behind). The secondary run would be a no-op, but it would fail in the end. The existing workflow would complete without errors.You can see how this played out in the release of
7.0.27, with this being the real run and this being the secondary run triggered.This PR adds a guard against that, by cancelling the workflow if it's triggered by a commit with
[skip ci], and then add that string to the version bump commit.How to test
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]