New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings: Add what's new page, remove release notes #23202

Merged

kasperpeulen merged 21 commits into next from kasper/whatsnew

Jul 4, 2023

Contributor

kasperpeulen commented Jun 23, 2023

Issue #23044

What I did

Implement What's new? page and remove release notes page

How to test

Checklist

Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
Make sure to add/update documentation regarding your changes
If you are deprecating/removing a feature, make sure to update
MIGRATION.MD

Maintainers

If this PR should be tested against many or all sandboxes,
make sure to add the ci:merged or ci:daily GH label to it.
Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]


          Implement What's new? page and remove release notes

fdcf1ef

kasperpeulen requested review from ndelangen and shilman

June 23, 2023 14:23

kasperpeulen added the feature request label

kasperpeulen added 5 commits

June 23, 2023 16:50


          Fix typing issues

58d86ab


          Disable what's new completely when feature is off

3add36f


          Disable what's new pages when build mode

41afd10


          Fall back to empty object for cache

c73db62


          Change icon and change default color for all notifications

89b75ff

yannbf reviewed

View reviewed changes

code/lib/core-server/src/presets/common-preset.ts Outdated Show resolved Hide resolved

kasperpeulen added 2 commits

June 23, 2023 18:37


          Put back story

ca249a3


          Only log for verbose

a2cc34e

yannbf approved these changes

View reviewed changes

Member

yannbf left a comment

LGTM! Haven't fully tested though, but all I tested was good!

shilman added the ui label


          Latest fixes

35e571e

shilman changed the title ~~Settings: Implement What's new? page and remove release notes page~~ Settings: Add What's new? page and remove release notes page

kasperpeulen commented

View reviewed changes

code/lib/cli/src/generate.ts Show resolved Hide resolved

kasperpeulen commented

View reviewed changes

code/lib/core-events/src/index.ts Outdated Show resolved Hide resolved


          Put url back

3af1704

kasperpeulen commented

View reviewed changes

code/lib/core-server/src/presets/common-preset.ts Outdated Show resolved Hide resolved

kasperpeulen commented

View reviewed changes

code/lib/core-server/src/presets/common-preset.ts Outdated Show resolved Hide resolved

kasperpeulen commented

View reviewed changes

code/lib/manager-api/src/modules/notifications.ts Show resolved Hide resolved

kasperpeulen commented

View reviewed changes

code/lib/manager-api/src/modules/notifications.ts Outdated Show resolved Hide resolved

kasperpeulen commented

View reviewed changes

code/lib/manager-api/src/modules/whatsnew.ts Outdated Show resolved Hide resolved

kasperpeulen commented

View reviewed changes

code/lib/manager-api/src/modules/whatsnew.ts Outdated Show resolved Hide resolved

kasperpeulen commented

View reviewed changes

code/lib/manager-api/src/modules/whatsnew.ts Show resolved Hide resolved

kasperpeulen self-assigned this

kasperpeulen added 3 commits

July 3, 2023 17:15


          Address review points

f2dbee9


          Merge branch 'next' into kasper/whatsnew

bdfc5aa


          Add version updates flag for now, as it still used without notification

600f991

kasperpeulen added 8 commits

July 3, 2023 17:21


          Merge remote-tracking branch 'origin/kasper/whatsnew' into kasper/wha…

daf8ae3

…tsnew


          Fix tests

c934f87


          Fix story


          Merge branch 'next' into kasper/whatsnew

86bce97


          Merge branch 'next' into kasper/whatsnew

def496d


          Fix story in a better way.

a1b0050


          Merge remote-tracking branch 'origin/kasper/whatsnew' into kasper/wha…

c62d08b

…tsnew


          Merge branch 'next' into kasper/whatsnew

a963daf

kasperpeulen merged commit c0b8096 into next

kasperpeulen deleted the kasper/whatsnew branch

July 4, 2023 13:59

github-actions bot mentioned this pull request

Release: Prerelease beta 7.1.0-beta.0 #23304

Merged

7 tasks

shilman changed the title ~~Settings: Add What's new? page and remove release notes page~~ Settings: Add what's new page, remove release notes

jonniebigodes mentioned this pull request

Docs: Adds the disable notification to the documentation #23417

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature request ui