Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactions: Fix deeply nested nodes in the panel debugger #23108

Merged
merged 9 commits into from
Jun 21, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Jun 16, 2023

Closes #

What I did

This PR does a couple of things:

  • Updates @storybook/testing-library, @storybook/jest and @storybook/test-runner to use next tag
  • The new version of @storybook/testing-library introduces user event14, so this PR adds a test case for that
  • Addon interactions had a bug with the syntax of user event 14 where it would completely crash Storybook, which is fixed in this PR
  • Many "Form" components used in sandbox templates were implemented wrong in the sense that the value of the form was not updated correctly, so I fixed those as well

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@yannbf yannbf added dependencies ci:daily Run the CI jobs that normally run in the daily job. labels Jun 16, 2023
@yannbf yannbf force-pushed the feat/upgrade-testing-lib branch from c2945bc to 4392b44 Compare June 16, 2023 14:58
@yannbf yannbf changed the title WIP: upgrade @storybook/testing-library WIP: Upgrade @storybook/testing-library Jun 16, 2023
@yannbf yannbf force-pushed the feat/upgrade-testing-lib branch 3 times, most recently from 2c05d05 to 5763841 Compare June 19, 2023 10:36
@socket-security
Copy link

socket-security bot commented Jun 19, 2023

New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives1 Size Publisher
@storybook/jest ⬆️ 0.2.0-future.0...0.1.1-next.1 None +0/-27 54.9 kB yannbf
@storybook/testing-library ⬆️ 0.2.0-future.1...0.2.0-next.0 None +0/-33 66.4 kB yannbf

Footnotes

  1. https://docs.socket.dev

@yannbf yannbf force-pushed the feat/upgrade-testing-lib branch from 5763841 to 91c4339 Compare June 19, 2023 12:48
@valentinpalkovic valentinpalkovic marked this pull request as draft June 19, 2023 14:20
- for Vue, Vue3, HTML, Svelte, Preact, HTML and Angular
@yannbf yannbf force-pushed the feat/upgrade-testing-lib branch from 80d149f to de35e3e Compare June 19, 2023 19:11
@yannbf yannbf marked this pull request as ready for review June 20, 2023 15:55
@yannbf yannbf changed the title WIP: Upgrade @storybook/testing-library Addon-interactions: Support deeply nested nodes in the panel debugger Jun 20, 2023
@yannbf yannbf added addon: interactions ci:merged Run the CI jobs that normally run when merged. bug and removed ci:daily Run the CI jobs that normally run in the daily job. dependencies labels Jun 20, 2023
@yannbf yannbf force-pushed the feat/upgrade-testing-lib branch from 2941885 to 63df870 Compare June 20, 2023 18:29
@yannbf yannbf requested a review from shilman June 20, 2023 21:32
@yannbf yannbf requested a review from ndelangen June 20, 2023 21:32
@ndelangen ndelangen merged commit 7cd93d3 into next Jun 21, 2023
@ndelangen ndelangen deleted the feat/upgrade-testing-lib branch June 21, 2023 08:07
@github-actions github-actions bot mentioned this pull request Jun 21, 2023
12 tasks
@shilman shilman changed the title Addon-interactions: Support deeply nested nodes in the panel debugger Addon-interactions: Fix deeply nested nodes in the panel debugger Jun 21, 2023
@shilman shilman changed the title Addon-interactions: Fix deeply nested nodes in the panel debugger Interactions: Fix deeply nested nodes in the panel debugger Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: interactions bug ci:merged Run the CI jobs that normally run when merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants