Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Improve monospace font stack #22477

Draft
wants to merge 8 commits into
base: next
Choose a base branch
from

Conversation

MichaelArestad
Copy link
Contributor

Relates #21619

What I did

Update monospace font stack so keyboard shortcuts look better on Mac

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@MichaelArestad MichaelArestad self-assigned this May 9, 2023
@MichaelArestad MichaelArestad added the maintenance User-facing maintenance tasks label May 9, 2023
@MichaelArestad MichaelArestad marked this pull request as draft May 9, 2023 16:54
@ndelangen
Copy link
Member

@cdedreuille Is this something you want to proceed with?

@ndelangen ndelangen changed the title Update monospace font stack UI: Improve monospace font stack Nov 28, 2023
@ndelangen
Copy link
Member

@cdedreuille the UI changes don't look right to me.

cc: @MichaelArestad

@MichaelArestad
Copy link
Contributor Author

@ndelangen I agree. It's not right. Fixing.

@MichaelArestad
Copy link
Contributor Author

The updated font stack should work in any browser on modern operating systems. It's not clear to me why Chromatic is rendering a non-monospace font.

@cdedreuille
Copy link
Contributor

Is this one still needed @MichaelArestad? Happy to help if this is needed.

@MichaelArestad
Copy link
Contributor Author

@cdedreuille I would love you to take a look as I think it is an improvement on what we had before.

Copy link

nx-cloud bot commented Mar 26, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 721ef19. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:normal maintenance User-facing maintenance tasks ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants