Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade react-dev-utils to 12.0.0 #17017

Closed

Conversation

Taillook
Copy link
Contributor

Issue: #16093

What I did

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented Dec 15, 2021

☁️ Nx Cloud Report

CI ran the following commands for commit b198081. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@nx-cloud
Copy link

nx-cloud bot commented Dec 15, 2021

Nx Cloud Report

We didn't find any information for the current pull request with the commit ac167d1.
You might need to set the 'NX_BRANCH' environment variable in your CI pipeline.

Check the Nx Cloud Github Integration documentation for more information.


Sent with 💌 from NxCloud.

@Taillook
Copy link
Contributor Author

Oops, disruptive changes...

@Taillook
Copy link
Contributor Author

Taillook commented Dec 15, 2021

e2e-teests-pnp and cra-bench is also failed by e7b8c49 in next branch.

@Taillook
Copy link
Contributor Author

Danger JS

Command did not finish within the time limit

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @Taillook!

As far as I can tell WatchMissingNodeModulesPlugin is the only thing we use from react-dev-utils, so if we're getting rid of that we can just remove the dependency entirely. @ndelangen do you have any thoughts on this?

The snapshot updates are unexpected. Any idea what's going on there?

@ndelangen
Copy link
Member

@shilman neither the CI failures: https://app.circleci.com/pipelines/github/storybookjs/storybook/22702/workflows/19d86086-b0dd-4f1a-ac6d-f5c0003d0600/jobs/356794

nor the snapshots updates ring any of my bells, I do not know what's causing them.. sorry..

@Taillook
Copy link
Contributor Author

Need to change the WatchMissingNodeModulesPlugin to not use it and upgrade react-scripts to v5.0.0

@Taillook Taillook marked this pull request as draft December 15, 2021 10:36
@Taillook
Copy link
Contributor Author

Taillook commented Dec 15, 2021

I'll take this PR down.
And resubmit a PR if it works in local.

(Lint error in local by next branch...

@Taillook Taillook closed this Dec 15, 2021
@Taillook Taillook deleted the chore/update-react-dev-utils branch March 2, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants