-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade react-dev-utils to 12.0.0 #17017
Conversation
☁️ Nx Cloud ReportCI ran the following commands for commit b198081. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Nx Cloud ReportWe didn't find any information for the current pull request with the commit ac167d1. Check the Nx Cloud Github Integration documentation for more information. Sent with 💌 from NxCloud. |
Oops, disruptive changes... |
e2e-teests-pnp and cra-bench is also failed by e7b8c49 in next branch. |
Danger JS
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much @Taillook!
As far as I can tell WatchMissingNodeModulesPlugin
is the only thing we use from react-dev-utils
, so if we're getting rid of that we can just remove the dependency entirely. @ndelangen do you have any thoughts on this?
The snapshot updates are unexpected. Any idea what's going on there?
@shilman neither the CI failures: https://app.circleci.com/pipelines/github/storybookjs/storybook/22702/workflows/19d86086-b0dd-4f1a-ac6d-f5c0003d0600/jobs/356794 nor the snapshots updates ring any of my bells, I do not know what's causing them.. sorry.. |
Need to change the WatchMissingNodeModulesPlugin to not use it and upgrade react-scripts to v5.0.0 |
I'll take this PR down. (Lint error in local by |
Issue: #16093
What I did
How to test
If your answer is yes to any of these, please make sure to include it in your PR.