Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Allow args/argTypes/component to be set via parameters for storiesOf back-compat #16791

Merged
merged 2 commits into from
Nov 26, 2021

Conversation

tmeasday
Copy link
Member

Issue: #16756

What I did

Restore old client-api way of passing args, argTypes, and component.

How to test

  • Is this testable with Jest or Chromatic screenshots?

@nx-cloud
Copy link

nx-cloud bot commented Nov 26, 2021

Nx Cloud Report

CI ran the following commands for commit 465a4be. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@shilman shilman added this to the 6.4 PRs milestone Nov 26, 2021
@shilman shilman changed the title Pass args/argTypes and component through parameters Core: Pass args/argTypes and component through parameters Nov 26, 2021
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants