Core: Sort the results of globby when constructing Story Index
#16788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For #16767 Apparently globby's order is non deterministic: sindresorhus/globby#131 I wasn't able to reproduce in our tests but definitely saw the behaviour in the issue.
Nx Cloud ReportCI ran the following commands for commit 044f731. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
shilman
changed the title
globby when constructing Story Indexglobby when constructing Story Index
shilman
requested changes
Nov 26, 2021
This was referenced Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #16767
What I did
Sort globbed files for consistent ordering.
Apparently globby's order is non deterministic: sindresorhus/globby#131
I wasn't able to reproduce in our tests but definitely saw the behaviour in @yannbf's reproduction.
How to test
I verified it fixes by changing the source in the reproduction.
I couldn't make the tests reproduce the problem, so not really.